Re: [UPDATED PATCH] Re: 2.5.63 - if/ifdef janitor work - actual bug found..

From: Bill Davidsen (davidsen@tmr.com)
Date: Fri Feb 28 2003 - 09:17:53 EST


On Thu, 27 Feb 2003 Valdis.Kletnieks@vt.edu wrote:

> On Thu, 27 Feb 2003 14:42:50 CST, Thomas Molina said:
>
> > Why couldn't it be MAY_OWNER_OVERRIDE??? There are occurrences of
> > MAY_OWNER_OVERRIDE
>
> Yes, but then the logic becomes:
>
> #if (a | b | MAY_OWNER_OVERRIDE) & (c | d | MAY_OWNER_OVERRIDE)
> #error ....
> #endif
>
> so it will *alway* error out. Tried it, it #errored, I looked at it
> more closely. The logic there is that it wants to have the two sets
> (SATTR, TRUNC, LOCK, LOCAL_ACCESS) and (READ, WRITE, EXEC, OVERRIDE)
> as disjoint sets of bits.

Thanks for that clarification, I had kept the original message to ask the
same question. Actually, while you are fixing this, how about putting in a
comment line saying what you just told us? It makes reading the code much
easier!

-- 
bill davidsen <davidsen@tmr.com>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.


- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 28 2003 - 22:00:48 EST