Re: [PATCH] eliminate warnings in generated module files

From: Horst von Brand (vonbrand@inf.utfsm.cl)
Date: Wed Feb 26 2003 - 12:02:31 EST


> In message
> <Pine.LNX.4.44.0302251930280.13501-100000@chaos.physics.uiowa.edu> you
> write:

[...]

> > Also, I don't really see any use for __optional at this point, so why add
> > it at all?

> >From ip_conntrack_core.c:

> #ifdef CONFIG_SYSCTL
> [snipped largeish data structure]
> #endif /*CONFIG_SYSCTL*/
>
> I'd love to frop the #ifdef and just mark them __optional: before that
> would just mean bloat, but when gcc 3.3 rolls in, they should vanish
> nicely.

If gcc will just discard it, why bother marking it specially? Unless it
gives ugly warnings, that is.

-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                     Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria              +56 32 654239
Casilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 28 2003 - 22:00:36 EST