Re: [PATCH 2.5.60 2/9] Update parport class driver to new module loader API.

From: Bob Miller (rem@osdl.org)
Date: Mon Feb 17 2003 - 12:15:02 EST

Next message: James Bourne: "Re: ext3 clings to you like flypaper"
Previous message: Magnus Naeslund\(f\): "Re: more signal locking bugs?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, Feb 15, 2003 at 11:16:42AM +0000, Christoph Hellwig wrote:
> On Fri, Feb 14, 2003 at 03:45:57PM -0800, Bob Miller wrote:
> > - void (*inc_use_count)(void);
> > + int (*inc_use_count)(void);
> > void (*dec_use_count)(void);
>
> This is broken. You need
>
> struct module *owner;
>
> here and use try_module_et/module_put before calling into the module.

Christoph,

Thanks for taking the time to review this. Your comments are similar
to Russell King's. I'll fix this and then re-submit. Thanks again.

-- 
Bob Miller					Email: rem@osdl.org
Open Source Development Lab			Phone: 503.626.2455 Ext. 17
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: James Bourne: "Re: ext3 clings to you like flypaper"
Previous message: Magnus Naeslund\(f\): "Re: more signal locking bugs?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:19 EST