Re: [PATCH][2.5][4/14] smp_call_function_on_cpu - MIPS

From: Justin Carlson (
Date: Fri Feb 14 2003 - 12:41:06 EST

On Fri, 2003-02-14 at 04:33, Zwane Mwaikambo wrote:
> +}
> +
> +int smp_call_function (void (*func) (void *info), void *info, int retry, int wait)
> +{
> + return smp_call_function_on_cpu(func, info, wait, cpu_online_map);
> }

IIRC, the semantics of smp_call_function() are to call the function on
all other cpus. So shouldn't this be

        return smp_call_function_on_cpu(func, info, wait, cpu_online_map & ~(1<<smp_processor_id()));


Also, maybe you were planning to do this in a future patch, but
shouldn't smp_call_function() be moved to non-arch-specific code, given
this change?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sat Feb 15 2003 - 22:00:55 EST