[PATCH][2.5.60 Trivial] Sysfs not handling show errors

From: Rusty Lynch (rusty@linux.co.intel.com)
Date: Wed Feb 12 2003 - 17:37:35 EST

Attempting to cat a sysfs file that returns an error will result in an
endless dump of garbage to the screen because the result of the specific
show operation was being saved to a size_t (unsigned) and then later
checked for a negative value.

Here is a trivial patch to fix the error.


--- fs/sysfs/inode.c.orig 2003-02-12 14:38:04.000000000 -0800
+++ fs/sysfs/inode.c 2003-02-12 14:38:39.000000000 -0800
@@ -210,7 +210,7 @@
         struct kobject * kobj = file->f_dentry->d_parent->d_fsdata;
         struct sysfs_ops * ops = buffer->ops;
         int ret = 0;
- size_t count;
+ ssize_t count;
         if (!buffer->page)
                 buffer->page = (char *) __get_free_page(GFP_KERNEL);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sat Feb 15 2003 - 22:00:45 EST