On Tue, 11 Feb 2003, Pavel Machek wrote:
> >
> > Hmm.. The stack grows downwards, are you sure you don't really mean
> >
> > mov $(wakeup_end-wakeup_code),%sp
> >
> > (because wakeup_end is the end of the wakeup_stack area..)
>
> Yes, I'm sure:
No. The code is crap. Please send a _fixed_ patch that clearly puts the
stack pointer at the _end_ of the stack.
What you are sure of is that is _happens_ to work by pure luck.
I'd rather have known-broken code in the kernel than code that works by
mistake. The former at least gets fixed.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Feb 15 2003 - 22:00:35 EST