Re: Fix random memory corruption during suspend-to-RAM resume

From: Linus Torvalds (
Date: Tue Feb 11 2003 - 15:23:55 EST

On Tue, 11 Feb 2003, Pavel Machek wrote:
> >
> > Hmm.. The stack grows downwards, are you sure you don't really mean
> >
> > mov $(wakeup_end-wakeup_code),%sp
> >
> > (because wakeup_end is the end of the wakeup_stack area..)
> Yes, I'm sure:

No. The code is crap. Please send a _fixed_ patch that clearly puts the
stack pointer at the _end_ of the stack.

What you are sure of is that is _happens_ to work by pure luck.

I'd rather have known-broken code in the kernel than code that works by
mistake. The former at least gets fixed.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sat Feb 15 2003 - 22:00:35 EST