Re: [PATCH] IDE: Do not call bh_phys() on buffers with invalid b_page.

From: Jens Axboe (axboe@suse.de)
Date: Wed Jan 29 2003 - 10:47:06 EST

Next message: Zwane Mwaikambo: "Re: Bootscreen"
Previous message: Stephan von Krawczynski: "Re: no more MTRRs available ?"
In reply to: Benjamin Herrenschmidt: "Re: [PATCH] IDE: Do not call bh_phys() on buffers with invalid b_page."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, Jan 29 2003, Benjamin Herrenschmidt wrote:
> On Wed, 2003-01-29 at 16:38, Jens Axboe wrote:
> > No, any b_data < PAGE_OFFSET is not wrong, that's the point. For highmem
> > b_page, b_data will be the offset into the page. So it could be 2048,
> > for instance.
>
> In the other if() case, yes ;)

b_data < PAGE_SIZE would not be a bug in the other case, if
PageHighmem(bh->b_page). If !PageHighmem(bh->b_page), then b_data <
PAGE_OFFSET would be a bug, yes.

But lets drop this now, it's getting way silly! :)

> All I wanted to spot is that < PAGE_OFFSET would catch the PAGE_SIZE bug
> as well ;) But that's not a problem in real life anyway it seems.

That is correct, but as I said it's nice to separate them because it's
two bugs really. And the one I wanted to catch was number 1, and that's
the one I put in. EOD?

-- Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Zwane Mwaikambo: "Re: Bootscreen"
Previous message: Stephan von Krawczynski: "Re: no more MTRRs available ?"
In reply to: Benjamin Herrenschmidt: "Re: [PATCH] IDE: Do not call bh_phys() on buffers with invalid b_page."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Jan 31 2003 - 22:00:22 EST