Re: [PATCH] IDE: Do not call bh_phys() on buffers with invalid b_page.

From: Benjamin Herrenschmidt (benh@kernel.crashing.org)
Date: Wed Jan 29 2003 - 09:57:46 EST

Next message: Steven Cole: "[PATCH] 2.5.59 add one help text to net/ipv4/netfilter/Kconfig"
Previous message: Denis Vlasenko: "Re: Bootscreen"
Next in thread: Jens Axboe: "Re: [PATCH] IDE: Do not call bh_phys() on buffers with invalid b_page."
Reply: Jens Axboe: "Re: [PATCH] IDE: Do not call bh_phys() on buffers with invalid b_page."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi, I just spotted this in the patch (but the code itself have been
there since 2.4.20-pre2).

> - if (((unsigned long) bh->b_data) < PAGE_SIZE)
> + if ((unsigned long) bh->b_data < PAGE_SIZE)

Didn't you meant PAGE_OFFSET and not PAGE_SIZE here ? I fail to see why
it would make any sense to compare a virtual address to PAGE_SIZE ;)

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Steven Cole: "[PATCH] 2.5.59 add one help text to net/ipv4/netfilter/Kconfig"
Previous message: Denis Vlasenko: "Re: Bootscreen"
Next in thread: Jens Axboe: "Re: [PATCH] IDE: Do not call bh_phys() on buffers with invalid b_page."
Reply: Jens Axboe: "Re: [PATCH] IDE: Do not call bh_phys() on buffers with invalid b_page."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Jan 31 2003 - 22:00:22 EST