Re: [patch 2.5] tg3.c: pci_{save,restore}_extended_state

From: Jeff Garzik (jgarzik@pobox.com)
Date: Fri Jan 24 2003 - 17:56:24 EST


Wiedemeier, Jeff wrote:
> But right now, the driver does not have enough information to make it a
> driver specific decision. INT_LINE may not be enough to determine the
> vector to claim for LSIs and "Message Data" may not be enough to
> determine the vector to claim for MSIs. What is there is the irq field
> in struct pci_dev.
[...]

> If it needs to be made a driver decision, there needs to be some way to
> communicate the correct vector information for whichever option the
> driver is using (if there already is and I missed it, please let me
> know). Otherwise, it seems that trying to match spec behavior given the
> hardware design or disabling MSI at config time for these devices (such
> as through quirks) are the options.

Just to add... I think that the proposed pci_using_msi() could certainly
store additional information in struct pci_dev, if it needed to...
whether it is stored in arch-specific sysdata or in generic struct
pci-dev, I leave as a question to the implementor ;-)

If "what is there is the irq field", then add the additional information
you want :)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jan 31 2003 - 22:00:13 EST