Re: [PATCH] eliminate pci_dev name

• Next message: Linus Torvalds: "Re: [PATCH] eliminate pci_dev name"
• Previous message: Richard B. Johnson: "Re: [PATCH] new timeout behavior for RPC requests on TCP sockets"
• In reply to: Jeff Garzik: "Re: [PATCH] eliminate pci_dev name"
• Next in thread: Linus Torvalds: "Re: [PATCH] eliminate pci_dev name"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, Nov 14, 2002 at 01:28:13PM -0500, Jeff Garzik wrote:
> Patch looks pretty good to me... seems like the obvious (and useful)
> cleanup.
>
> You should increase DEVICE_NAME_SIZE in include/linux/device.h from 80
> to 90, though. I assume you don't want to take the other option, which
> is to audit every use and all the id strings to make sure they're short
> enough. In fact, IIRC, device name increased in size due to some really
> long PCI names, so I think '90' will wind up the preferred value in any
> case.

I didn't break anything that wasn't already broken.

- strcpy(dev->dev.name, dev->name);

Who wants a smack?

-- 
Revolutions do not require corporate support.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Linus Torvalds: "Re: [PATCH] eliminate pci_dev name"
• Previous message: Richard B. Johnson: "Re: [PATCH] new timeout behavior for RPC requests on TCP sockets"
• In reply to: Jeff Garzik: "Re: [PATCH] eliminate pci_dev name"
• Next in thread: Linus Torvalds: "Re: [PATCH] eliminate pci_dev name"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:33 EST