Duplicated code in grab_cache_page, __grab_cache_page, ...

From: Brice Goglin (bgoglin@ens-lyon.fr)
Date: Wed Nov 13 2002 - 06:06:01 EST

Next message: Anders Gustafsson: "linux/elf.h vs linux/module.h [was: 2.5-bk AT_GID clash]"
Previous message: David S. Miller: "Re: [PATCH] module_name()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi,

I noticed a large part of code which looks duplicated
in __grab_cache_page, grab_cache_page (and some parts of
do_generic_file_read (in the "no_cached_page:" section))
in mm/filemap.c.

I do not see the real difference between grab_cache_page
and __grab_cache_page (except the additional
"struct page *cached_page" argument).
The fact that the first one is exported while the second
one is static looks strange to me.
Why not exporting both of them if the are really different ?
Or why not merging them into a general purpose grab_cache_page ?

I've seen some small changes during 2.5 developpement
(grab_cache_page moved to pagemap.h, __grab_cache_page
got a new argument).
I'd like to know whether you planned to clean this point
in future 2.5 revisions ?

Regards

--
Brice Goglin,
Laboratoire de l'Informatique du Parallelisme
ENS Lyon - 46 allée d'Italie
69007 LYON - France
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Anders Gustafsson: "linux/elf.h vs linux/module.h [was: 2.5-bk AT_GID clash]"
Previous message: David S. Miller: "Re: [PATCH] module_name()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:28 EST