Re: PATCH 2.4: scsi and BLK_STATS

From: Christoph Hellwig (hch@infradead.org)
Date: Tue Nov 12 2002 - 20:37:17 EST


On Wed, Nov 13, 2002 at 02:30:59AM +0100, Matthias Urlichs wrote:
> That may be a matter of style, but I would strongly prefer these to be
>
> #define req_new_io(_a,_b,_c) do {} while(0)
> #define req_merge_io(_a) do {} while(0)
> #define req_finished_io(_a) do {} while(0)
>
> instead ...

In kernelspace inlines are usually preferred over macros, that's why
I wrote it that way. I must adimt that I don't really care a lot
personally..

> anyway, please disregard my patch and add
>
> #include <linux/genhd.h>
>
> in scsi/scsi_lib.c. :-/

It already gets genhd.h through blk.h -> blkdev.h.. :)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:27 EST