On Mon, Nov 11, 2002 at 05:37:10PM -0600, Peter Samuelson wrote:
> [Tom Rini]
> > First, does anyone see any problems with the patch itself?
>
> Well,
>
> > - str_config += sizeof("CONFIG_") - 1;
> > + str_config += strlen(str_split_token);
>
> it does seem a bit inefficient to call strlen() for every single line
> of every single source file. Perhaps today's compilers know that
> strlen() is invariant and has no side effects, but I vote you go ahead
> and optimise it explicitly.
Sounds good, thanks.
-- Tom Rini (TR1265) http://gate.crashing.org/~trini/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:25 EST