Re: [patch] make device mapper compile on 2.5.4x

From: Alexander Viro (viro@math.psu.edu)
Date: Mon Nov 11 2002 - 18:23:00 EST


On Mon, 11 Nov 2002, Bernd Eckenfels wrote:

> - set_device_ro(dm_kdev(md), 0/*(param->flags & DM_READONLY_FLAG)*/);
> + bdev = bdget(kdev_t_to_nr(dm_kdev(md)));
> + if (!bdev)
> + return -ENXIO;
> + set_device_ro(bdev, (param->flags & DM_READONLY_FLAG));
> + bdput(bdev);

That is simply wrong. set_device_ro() works only on opened block_device.
Correct fix is to use set_disk_ro() and it's already in the tree (1.830
on bkbits).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:23 EST