Re: [TRIVIAL] Re: UP went into unexpected trashing

From: Linus Torvalds (torvalds@transmeta.com)
Date: Fri Nov 08 2002 - 15:10:14 EST


On Sat, 9 Nov 2002, Dipankar Sarma wrote:
>
> Or add a check in there. I can't figure out a way to avoid the extra
> conditional branch anyway :)

I'd actually rather change the calling convention, and say that the only
valid test is for testing the return value "being in range".

And it's not strictly even a calling convention _change_ - it's always
been that way. See the original user, ie the minix filesystem:

        if ((j = minix_find_first_zero_bit(bh->b_data, 8192)) < 8192) {
                ...

and it's really a documentation fix/update to just tell people about this.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:16 EST