Re: [RFC] Templates and tweaks (for size performance and more)

From: Tom Rini (trini@kernel.crashing.org)
Date: Thu Nov 07 2002 - 17:06:29 EST


On Thu, Nov 07, 2002 at 09:03:04PM +0000, Russell King wrote:
> On Thu, Nov 07, 2002 at 12:09:10PM -0700, Tom Rini wrote:
> > The following is vs current 2.5 BK and has been lightly tested on PPC
> > (and compiled on i386). This creates the default files for all current
> > arches, and adapts ARM and ia64 as well to show how to override a
> > generic param with an arch-specific one (and removes
> > CONFIG_FORCE_MAX_ZONEORDER).
>
> This isn't a "tweak" on ARM as in a user-adjustable value. It needs to
> specifically be reduced to prevent things from blowing up.

It is however, a "tweak" of the default value of 11. I'll add a comment
about this for the next version. And if it can be less than 9, it is
user-adjustable, it just has to be adjusted between 1 and 9.

> > +/* This is the number of free areas per zone to manage, but the max
> > + * number determines the maximum order of a page allocation request
> > + * as well. */
> > +/* Default: 11 */
> > +#if defined(ASSABET_NEPONSET0) || defined(SA1100_ADSBITSY) || \
> > + defined(SA1100_BADGE4) || defined(SA1100_CONSUS) || \
> > + defined(SA1100_GRAPHICSMASTER) || defined(SA1100_JORNADA720) || \
> > + defined(ARCH_LUBBOCK) || defined(SA1100_PFS168) || \
> > + defined(SA1100_PT_SYSTEM3) || defined(SA1100_XP860)
> > +#undef TWEAK_MAX_ORDER
> > +#define TWEAK_MAX_ORDER 9
> > +#endif
>
> And the reason we have it in the configuration rather than the code is
> to get rid of crap like the above.

But having that as one line in arch/arm/Kconfig looks any better?

-- 
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 07 2002 - 22:00:50 EST