Re: [PATCH] 2.5.46: epoll_wait can return too many events

• Next message: Andrew Morton: "Re: Strange panic as soon as timer interrupts are enabled (recent 2.5)"
• Previous message: Christopher Li: "Re: [PATCH] Fix bug in ext3 htree rename: doesn't delete old name, leaves ino with bad nlink"
• In reply to: Jay Vosburgh: "[PATCH] 2.5.46: epoll_wait can return too many events"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, 6 Nov 2002, Jay Vosburgh wrote:

>
> The logic in fs/eventpoll.c:ep_events_transfer() to bundle events can
> return more than the requested number of events (because the event count is
> only incremented for each bundle); this will scribble on memory beyond the
> end of the user's buffer. The fix is to test against the bundle size
> (ebufcnt) plus the event count (eventcnt).
>
> Also, passing maxevents <= 0 to epoll_wait() causes the system to
> lock up; the fix is to return EINVAL if maxevents is <= 0.

Thanks Jay. Got it.
Linus please drop 0.32, I'll make 0.33 right now ...

- Davide

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Andrew Morton: "Re: Strange panic as soon as timer interrupts are enabled (recent 2.5)"
• Previous message: Christopher Li: "Re: [PATCH] Fix bug in ext3 htree rename: doesn't delete old name, leaves ino with bad nlink"
• In reply to: Jay Vosburgh: "[PATCH] 2.5.46: epoll_wait can return too many events"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Nov 07 2002 - 22:00:45 EST