[PATCH 2.5] invalid irqs accepted in serial pci driver

From: Brian Murphy (brm@murphy.dk)
Date: Mon Nov 04 2002 - 16:13:47 EST


Hi,
        the pci serial driver should not allow the configuration of
devices which return an irq of 255 - it is illegal according to the
standard and means the device has not had an irq configured.

The patch adds rejection of these invalid devices.

/Brian

--- drivers/serial/8250_pci.c 1 Nov 2002 23:26:57 -0000 1.4
+++ drivers/serial/8250_pci.c 4 Nov 2002 21:05:31 -0000
@@ -735,6 +735,9 @@
         memset(&serial_req, 0, sizeof(serial_req));
         for (k = 0; k < board->num_ports; k++) {
                 serial_req.irq = get_pci_irq(dev, board, k);
+ if (serial_req.irq == 255)
+ /* not initialised */
+ break;
                 if (get_pci_port(dev, board, &serial_req, k))
                         break;
 #ifdef SERIAL_DEBUG_PCI
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 07 2002 - 22:00:34 EST