Re: swsusp: don't eat ide disks

From: Jens Axboe (axboe@suse.de)
Date: Mon Nov 04 2002 - 04:39:47 EST


On Sun, Nov 03 2002, Linus Torvalds wrote:
> struct request *rq;
>
> rq = blk_get_request(q, WRITE, __GFP_WAIT);
> rq->flags = REQ_BLOCK_PC;
> rq->data = NULL;
> rq->data_len = 0;
> rq->timeout = 5*HZ; /* Or whatever */
> memset(rq->cmd, 0, sizeof(rq->cmd));
> rq->cmd[0] = SYNCHRONIZE_CACHE;
> .. fill in whatever bytes the SYNCHRONIZE_CACHE cmd needs ..
> rq->cmd_len = 10;
> err = blk_do_rq(q, bdev, rq);
> blk_put_request(rq);

Warning, redundant blk_put_request().

I agree with Linus' example though. The queue is nice that way, for
completely synchronizing access to the device.

> and you're done. The above should work pretty much on all block drivers
> out there, btw: the ones that don't understand SCSI commands should just
> ignore requests that aren't the regular REQ_CMD commands.

Except ide drives?

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 07 2002 - 22:00:32 EST