Hi!
> > Here's patch to prevent random scribling over disks during
> > suspend... In the meantime alan killed (unreferenced at that time)
> > idedisk_suspend() and idedisk_release(), so I have to reintroduce
> > them.
>
> Please fix this at a different level. idedisk is not the place to be
> doing this. If the device layer is doing the right thing then the
> request queue will be idle.
How can I wait for all requests to be finished? Should it be at
ll_rw_blk level?
Anyway if I want disk to be spinned down (so their caches are
flushed), some kind of idedisk_suspend is required, right?
> > + .gen_driver = {
> > + .suspend = idedisk_suspend,
> > + .resume = idedisk_resume,
> > + }
>
> Some disks are going to be settint their own power methods too.
Fine with me as long as they call idedisk_suspend() first ;-).
Pavel
-- Casualities in World Trade Center: ~3k dead inside the building, cryptography in U.S.A. and free speech in Czech Republic. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Nov 07 2002 - 22:00:26 EST