Re: ide-cd still borken for me in 2.5.45

From: Jens Axboe (axboe@suse.de)
Date: Sat Nov 02 2002 - 09:54:51 EST

On Sat, Nov 02 2002, Thomas Molina wrote:
> On Sat, 2 Nov 2002, Jens Axboe wrote:
>
> > > Well that was quick. 2.5.42 works correctly. The problems begin with
> > > 2.5.43.
> >
> > Ok, so Linus broke it :-)
> >
> > Please boot with this patch, it looks like a command length screwup.
>
> Your patch produced:
>
> hdc: starting 5a, len = 24

ok looks fine, now please try (on top of the other one):

--- /opt/kernel/linux-2.5.45/drivers/ide/ide-cd.c 2002-11-01 11:31:53.000000000 +0100
+++ drivers/ide/ide-cd.c 2002-11-02 15:54:16.000000000 +0100
@@ -906,7 +906,7 @@
         ide_set_handler(drive, handler, rq->timeout, cdrom_timer_expiry);
 
         /* Send the command to the device. */
- HWIF(drive)->atapi_output_bytes(drive, rq->cmd, sizeof(rq->cmd));
+ HWIF(drive)->atapi_output_bytes(drive, rq->cmd, 12);
 
         /* Start the DMA if need be */
         if (info->dma) 

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Thu Nov 07 2002 - 22:00:24 EST