Re: [announce] swap mini-howto

From: Andrew Morton (akpm@digeo.com)
Date: Sat Nov 02 2002 - 05:02:21 EST


Jeff Garzik wrote:
>
> ...
> That said, I would like to again point out that using sparse swapfiles
> should still be discouraged. It may be supported, but it's much better
> for system performance and stability, IMO, if the sysadmin makes certain
> all swapfiles are 100% allocated before they are mentioned to the swap
> subsystem.
>

That got stamped out. swapon will fail if the file isn't fully
instantiated on disk:

static int setup_swap_extents(struct swap_info_struct *sis)
{
        ...
                        block = bmap(inode, probe_block + block_in_page);
                        if (block == 0)
                                goto bad_bmap;
        ...

bad_bmap:
        printk(KERN_ERR "swapon: swapfile has holes\n");
        ret = -EINVAL;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 07 2002 - 22:00:23 EST