Re: might_sleep() in copy_{from,to}_user and friends?

From: Manfred Spraul (manfred@colorfullife.com)
Date: Fri Nov 01 2002 - 08:47:00 EST

Next message: Roman Zippel: "Re: Where's the documentation for Kconfig?"
Previous message: Takashi Iwai: "Re: [PATCHSET 22/25] add support for PC-9800 architecture (sound alsa)"
Maybe in reply to: Arnd Bergmann: "might_sleep() in copy_{from,to}_user and friends?"
Next in thread: Arnd Bergmann: "Re: might_sleep() in copy_{from,to}_user and friends?"
Reply: Arnd Bergmann: "Re: might_sleep() in copy_{from,to}_user and friends?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Arnd wrote:
> I have been looking for more places in 2.5 that can be marked
> might_sleep() and noticed that all the functions in asm/uaccess.h
> are not marked although they sleep if the memory they access
> has to be paged in.
>

Good idea.
There is some abuse of __get_user to identify bad pointers:
show_registers in the oops codepath, mm/slab.c in the /proc/slabinfo code.

Could you omit the test from the __ versions?

-- Manfred

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Roman Zippel: "Re: Where's the documentation for Kconfig?"
Previous message: Takashi Iwai: "Re: [PATCHSET 22/25] add support for PC-9800 architecture (sound alsa)"
Maybe in reply to: Arnd Bergmann: "might_sleep() in copy_{from,to}_user and friends?"
Next in thread: Arnd Bergmann: "Re: might_sleep() in copy_{from,to}_user and friends?"
Reply: Arnd Bergmann: "Re: might_sleep() in copy_{from,to}_user and friends?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Nov 07 2002 - 22:00:20 EST