Re: [RFC] generic_file_direct_IO() argument changes for AIO

• Next message: Nicholas Wourms: "Re: [PATCH] 0/11 Ext2/3 Updates: Extended attributes, ACL, etc."
• Previous message: David Fries: "ext3 dies without inodes"
• In reply to: Badari Pulavarty: "[RFC] generic_file_direct_IO() argument changes for AIO"
• Next in thread: Chuck Lever: "Re: [RFC] generic_file_direct_IO() argument changes for AIO"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Badari Pulavarty wrote:
>
> Hi,
>
> Inorder to support AIO for raw/O_DIRECT, I need to add "struct kiocb *"
> to generic_file_direct_IO() and all direct_IO() ops.
>
> generic_file_direct_IO(int rw, struct file *file, const struct iovec *iov,
> loff_t offset, unsigned long nr_segs)
>
> Instead of adding a new argument, I propose replace
>
> "struct file *file" argument with "struct kiocb *iocb"
>
> One can get "filp" from iocb->ki_filp.
>
> Any objections ?
>

OK by me.

BTW, while you're poking around in there could you please rename
generic_direct_IO() to blockdev_direct_IO() and move
generic_file_direct_IO() back into filemap.c?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Nicholas Wourms: "Re: [PATCH] 0/11 Ext2/3 Updates: Extended attributes, ACL, etc."
• Previous message: David Fries: "ext3 dies without inodes"
• In reply to: Badari Pulavarty: "[RFC] generic_file_direct_IO() argument changes for AIO"
• Next in thread: Chuck Lever: "Re: [RFC] generic_file_direct_IO() argument changes for AIO"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Oct 31 2002 - 22:00:43 EST