Re: [BENCHMARK] AIM Independent Resource Benchmark results for kernel-2.5.44

From: Nathan Straz (nstraz@sgi.com)
Date: Tue Oct 29 2002 - 10:28:00 EST


On Tue, Oct 29, 2002 at 12:17:38AM +0100, Jakob Oestergaard wrote:
> On Mon, Oct 28, 2002 at 12:28:39PM -0600, Nathan Straz wrote:
> > > The AIM7/AIM9 new_raph is broken code. The convergence loop termination
> > > conditional looks something like:
> > > if (delta == 0) break;
> > > for a type "double" delta. You ought to change that to be something
> > > like:
> > > if (delta <= 0.00000001L) break;
> >
> > I usually specify the compiler flag -ffloat-store and that fixes the
> > issue for me.
>
> Maybe that will work as a work-around. But it is nothing but a
> work-around. The previous poster was right - the code is broken.

/me looks at the code

        /*
         * Step 4: if |p - p0| < TOL then terminate successfully
         */
        delta = fabs(p - p0);
        if (delta == 0.0)
                break;

Ok, I'll admit that the code does look broken, especially with regard to
the comment *in* the code.

Is anyone from Caldera still maintaining this code or shall I create a
CVS module as part of LTP?

-- 
Nate Straz                                              nstraz@sgi.com
sgi, inc                                           http://www.sgi.com/
Linux Test Project                                  http://ltp.sf.net/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Oct 31 2002 - 22:00:42 EST