Re: [PATCH] use seq_file for /proc/swaps

• Next message: Steffen Persvold: "kernel BUG in page_alloc.c (rmqueue function)"
• Previous message: Meelis Roos: "PIIX4 IDE w/ MWDMA disk still broken in 2.4.20-rc1(bk)"
• In reply to: Randy.Dunlap: "[PATCH] use seq_file for /proc/swaps"
• Next in thread: Randy.Dunlap: "Re: [PATCH] use seq_file for /proc/swaps"
• Reply: Randy.Dunlap: "Re: [PATCH] use seq_file for /proc/swaps"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, Oct 28, 2002 at 09:36:44PM -0800, Randy.Dunlap wrote:
>
> Hi,
>
> This patch to 2.5.44 converts /proc/swaps to use seq_file.
>
> It's basically the same patch that I posted a few days ago
> with locking added [using swap_list_lock() and
> swap_list_unlock(), as directed by Al].
>
> Any comments on this version?

Looks fine. Any chance you could move proc_swaps_operations and
the entry creating to swapfile.c so when uclinux makes this file
conditional on CONFIG_SWAP we don't need ifdefs in proc_misc.c?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Steffen Persvold: "kernel BUG in page_alloc.c (rmqueue function)"
• Previous message: Meelis Roos: "PIIX4 IDE w/ MWDMA disk still broken in 2.4.20-rc1(bk)"
• In reply to: Randy.Dunlap: "[PATCH] use seq_file for /proc/swaps"
• Next in thread: Randy.Dunlap: "Re: [PATCH] use seq_file for /proc/swaps"
• Reply: Randy.Dunlap: "Re: [PATCH] use seq_file for /proc/swaps"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Oct 31 2002 - 22:00:41 EST