Re: [PATCH,RFC] faster kmalloc lookup

From: Nikita Danilov (Nikita@Namesys.COM)
Date: Mon Oct 28 2002 - 08:26:33 EST


Marcus Alanen writes:
> >Most kmalloc calls get constant size argument (usually
> >sizeof(something)). So, if switch() is used in stead of loop (and
> >kmalloc made inline), compiler would be able to optimize away
> >cache_sizes[] selection completely. Attached (ugly) patch does this.
>
> Perhaps a compile-time test to check if the argument is
> a constant, and only in that case call your new kmalloc, otherwise
> a non-inline kmalloc call? With your current patch, a non-constant
> size argument to kmalloc means that the function is inlined anyway,
> leading to unnecessary bloat in the resulting image.

Yes, exactly.

>
> Marcus
>

Nikita.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Oct 31 2002 - 22:00:36 EST