Re: 2.5.44-ac4 scsi CDROMEJECT problem

From: Nyk Tarr (nyk@giantx.co.uk)
Date: Mon Oct 28 2002 - 06:41:52 EST

Next message: juanba: "RAM root file system"
Previous message: Norbert Rooss: "tty drivers: Is put_char mandatory?"
In reply to: Jens Axboe: "Re: 2.5.44-ac4 scsi CDROMEJECT problem"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, Oct 28, 2002 at 11:57:54AM +0100, Jens Axboe wrote:
> On Mon, Oct 28 2002, Nyk Tarr wrote:
> > On Mon, Oct 28, 2002 at 09:15:07AM +0100, Jens Axboe wrote:
> > > On Sun, Oct 27 2002, Nyk Tarr wrote:
> > > > Hi
> > > >
> > > > This patch of Jens Axboe was missing from 2.5.44-ac4. Was this by design
> > > > or accidental?
> > >
> > > Please check blk_do_rq(), it sets rq_dev and rq_disk. So it's indeed
> > > intentional. Since you ask, do you have problems ejecting?
> >
> > Yup.
> >
> > I can only see rq -> rq_dev being set in sg_io(), but then again, you
> > could write the amount of C I know on a small postage stamp. ^_^
> >
> > recompiled with the two assignments in under CDROMEJECT it works fine.
>
> I just checked the -ac4 patch, and bits are indeed missing. The
> recommended patch against -ac4 is:
>
[snip]
>
> I think Alan dropped this last bit (or maybe it didn't apply for him,
> dunno), at least I know it was sent.

Applies clean here. I'll try it later.

Thanks.
Nyk

-- 
/__
\_|\/
   /\
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: juanba: "RAM root file system"
Previous message: Norbert Rooss: "tty drivers: Is put_char mandatory?"
In reply to: Jens Axboe: "Re: 2.5.44-ac4 scsi CDROMEJECT problem"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Oct 31 2002 - 22:00:36 EST