Re: [PATCH]: linux-2.5.44uc1 (MMU-less support)

From: Sam Ravnborg (sam@ravnborg.org)
Date: Sun Oct 27 2002 - 02:48:09 EST


On Sun, Oct 27, 2002 at 01:04:07PM +0900, Miles Bader wrote:
> It may be more readable, but I don't think you can say it's the `normal way
> of doing it,' at least in linux -- almost all the arch Makefiles have code
> pretty much identical to Greg's (presumably all derived from a single
> original source).
>
> Perhaps they should all be changed.
Well, most arch Makefiles could use some cleaning up - also with respect
to te construct above. My point was that there is no need to list
prerequisites as several rules when they can be combined as one.
And the fact that a temporary is generated could well be hidden.
By the way I made a mistake, it should be:

include/asm-$(ARCH)/asm-offsets.h: arch/$(ARCH)/kernel/asm-offsets.s \
                                 include/asm include/linux/version.h \
                                 include/config/MARKER
        @echo -n ' Generating $@'
        @$(generate-asm-offsets.h) < $< > $@.tmp
        @$(update-if-changed)

        Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Oct 31 2002 - 22:00:32 EST