Dave Jones wrote:
>On Fri, Oct 25, 2002 at 08:04:45PM -0400, Jeff Garzik wrote:
>
> > Not really... we print out other information that is duplicated N times,
> > because it is the common case that N-way systems have matched processors
> > with matched capabilities.
>
>Not really. We print out the 'duplicate' info because it's read that
>way from different CPUs. The smp_num_siblings is a single global
>variable. Theoretically, the other stuff /could/ change in an
>asymetrical system, but the num_siblings thing is constant.
>
>
Sure, but you snipped the other part of the argument :) Printing stuff
only once is changes the format which has previously been to print out
the same fields [but not necessarily the same values] for each CPU; so
the alternative is to create /proc/global_cpu_info just to print out
num-siblings only once :) IOW, I don't see it as a big deal to print
out the duplicated info, because that maintains the other assumptions
about output format.
That said, on IRC my preference was to create smp_num_siblings[] and
store the info per-cpu. But right now that's only for software
engineering masturbation :) since it would store the same value N times
on current CPUs.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Oct 31 2002 - 22:00:30 EST