Re: [PATCH] NMI request/release, version 6 - "Well I thought the last one was ready"

From: John Levon (levon@movementarian.org)
Date: Thu Oct 24 2002 - 20:39:52 EST

On Thu, Oct 24, 2002 at 08:22:33PM -0500, Corey Minyard wrote:

> http://home.attbi.com/~minyard/linux-nmi-v6.diff.

                case NOTIFY_DONE:
                default:
                }

This needs to be :

                case NOTIFY_DONE:
                default:;
                }

or later gcc's whine.

+ * handler, if you have a fast-path handler there's another tie-in
+ * for you. See the oprofile code.

You forgot to remove this comment.

        if (!list_empty(&(handler->link)))
                return EBUSY;

This wants to be -EBUSY (it eventually gets returned to userspace via
oprofile, and is more common anyway).

static int nmi_std (void * dev_id,
                    struct pt_regs * regs,
                    int cpu,
                    int handled)

I don't think this matches the usual kernel style.

I think the rest looks OK, I'll find some time to play with oprofile
side of this.

thanks
john 

-- 
"This is playing, not work, therefore it's not a waste of time."
	- Zath
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Thu Oct 31 2002 - 22:00:26 EST