On Mon, Oct 07, 2002 at 02:16:29PM -0700, Andrew Morton wrote:
> Linus Torvalds wrote:
> >
> > On 7 Oct 2002, Alan Cox wrote:
> > >
> > > Factoring the uid/gid/pid in actually may help in other ways. If we are
> > > doing it by pid or by uid we will reduce the interleave of multiple
> > > files thing you sometimes get
> >
> > 'pid' would probably work better than what we have now, even though I bet
> > it would get confused by a large number of installers (ie "make install"
> > in just about any project will use multiple different processes to copy
> > over separate subdirectories. In the X11R6 tree it uses individual "cp"
> > processes for each file!)
> >
> > The session ID would avoid some of that, but they both have a fundamental
> > problem: neither pid nor session ID is actually saved in any directory
> > structure, so it's quite hard to use that as a heuristic for whether a new
> > file should go into the same directory group as the directory it is
> > created in.
> >
> > That's why "uid" would work better.
>
> Sound good to me. At leat this puts a veneer of respectability over
> decapitating find_group_other(), which is really what we all want
> to do anyway ;)
>
> > The uid has a different issue, though,
> > namely the fact that when user directories are created, they are basically
> > always created as uid 0 first, and then a "chown" - which means that the
> > user heuristic wouldn't actually trigger at the right time. So the
> > heuristic couldn't be just "newfile->uid == directory->uid", it would have
> > to be something better.
>
> Last time, Al suggested that we always use the find_group_other() approach
> if the directory is being made at the top-level of the filesystem. So
> if /home is a mountpoint, the user directories get spread out.
>
> I think this, and the UID comparison will be good enough.
How about UID == 0? Other than install and restore tree
creation (top levels) is done by root but tree population
tends to be done by non-root. That would cause /home/* or
/project/* etc to be in seperate groups but the contents of
each would (mostly) have locality.
Let's see, that would be..
- if (S_ISDIR(mode))
+ if (S_ISDIR(mode) && !current->fsuid)
group = find_group_dir(sb, dir->u.ext2_i.i_block_group);
else
group = find_group_other(sb, dir->u.ext2_i.i_block_group);
-- ________________________________________________________________ J.W. Schultz Pegasystems Technologies email address: jw@pegasys.wsRemember Cernan and Schmitt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:01:02 EST