On 5 Oct 2002, Andi Kleen wrote:
|>"Matt D. Robinson" <yakker@aparity.com> writes:
|>
|>> diff -urN -X /home/bharata/dontdiff linux-2.5.40/arch/i386/kernel/i386_ksyms.c linux-2.5.40+lkcd/arch/i386/kernel/i386_ksyms.c
|>> --- linux-2.5.40/arch/i386/kernel/i386_ksyms.c Tue Oct 1 12:36:59 2002
|>> +#if defined(CONFIG_X86) || defined(CONFIG_ALPHA)
|>> +EXPORT_SYMBOL(page_is_ram);
|>> +#endif
|>
|>This ifdef in i386_ksyms.c doesn't make much sense...
If the rest of the architectures used page_is_ram(), this
wouldn't be a problem, but not all do. And since we use
it/need it, that's the reason for the addition.
|>> +#ifdef CONFIG_SMP
|>> +extern irq_desc_t irq_desc[];
|>> +extern unsigned long irq_affinity[];
|>> +EXPORT_SYMBOL(irq_affinity);
|>> +EXPORT_SYMBOL(irq_desc);
|>> +extern void dump_send_ipi(void);
|>> +EXPORT_SYMBOL(dump_send_ipi);
|>> +extern int (*dump_ipi_function_ptr)(struct pt_regs *);
|>> +EXPORT_SYMBOL(dump_ipi_function_ptr);
|>> +extern void (*dump_trace_ptr)(struct pt_regs *);
|>> +EXPORT_SYMBOL(dump_trace_ptr);
|>> +extern void show_this_cpu_state(int, struct pt_regs *, struct task_struct *);
|>> +EXPORT_SYMBOL(show_this_cpu_state);
|>
|>Before adding all these ugly declarations I would just declare the file where
|>whey are exported from as 'x-obj' and put them directly to where the
|>functions live.
Okee, I'll start looking into doing this. That'll break out this
whole patch (assuming there's something else that can be done for
the page_is_ram() mechanism).
|>-Andi
--Matt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:49 EST