Re: export of sys_call_table

From: Andi Kleen (ak@suse.de)
Date: Fri Oct 04 2002 - 08:01:25 EST


"Brian F. G. Bidulock" <bidulock@openss7.org> writes:

> void *dataptr, int band, int flags)
> {
> int ret =3D -ENOSYS;
> read_lock(&streams_call_lock);

I don't think you really want to use any spinlocks this way. They would
make sleeping impossible and you could never legally do a copy_from/to_user
in your system call. And how else would you access dataptr ?

More likely you want an atomic_inc(&modulecounter) or perhaps a rw
semaphore.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:43 EST