Re: [PATCH] IPv6: Miscellaneous clean-ups

From: David S. Miller (davem@redhat.com)
Date: Thu Oct 03 2002 - 12:36:17 EST


   From: YOSHIFUJI Hideaki / $B5HF#1QL@(B <yoshfuji@linux-ipv6.org>
   Date: Fri, 04 Oct 2002 01:13:15 +0900 (JST)

   @@ -1187,7 +1187,7 @@
            ASSERT_RTNL();
    
            memset(&addr, 0, sizeof(struct in6_addr));
   - addr.s6_addr[15] = 1;
   + addr.s6_addr32[3] = __constant_htonl(0x00000001);
    
Do not use __constant_htonl() in runtime code, use htonl().
Arnaldo de Melo told you this the other day for another one
of your patches, so you must fix this kind of stuff up before
I'll apply any of your patches which have this problem.

Only use __constant_htonl() for compile time initialization of data
built into the kernel.

Otherwise I like you patch, please fix it up so I may apply it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:41 EST