Hi!
There's extremely stupid bug in sleep.c -- it will only alow user to
enter *unsupported* states. What's even worse that I remember fixing
that once before, and *it was merged to mainline*.
Please, really merge it to all copies so it is not reintroduced again.
[Oh, at it also makes S4 transition fail when SWSUSP support is not
there.]
Pavel
--- clean/drivers/acpi/sleep.c 2002-09-22 23:46:56.000000000 +0200
+++ linux-swsusp/drivers/acpi/sleep.c 2002-10-01 23:38:48.000000000 +0200
@@ -329,8 +329,8 @@
state_string[count] = '\0';
state = simple_strtoul(state_string, NULL, 0);
-
- if (sleep_states[state])
+
+ if (!sleep_states[state])
return_VALUE(-ENODEV);
#ifdef CONFIG_SOFTWARE_SUSPEND
@@ -338,7 +338,10 @@
software_suspend();
return_VALUE(count);
}
+#else
+ return_VALUE(-ENODEV);
#endif
+
status = acpi_suspend(state);
if (ACPI_FAILURE(status))
-- Worst form of spam? Adding advertisment signatures ala sourceforge.net. What goes next? Inserting advertisment *into* email? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:29 EST