Re: DAC960 in 2.5.38, with new changes

From: David Mosberger (davidm@napali.hpl.hp.com)
Date: Mon Sep 23 2002 - 14:19:02 EST

Hi Dave,

>>>>> On Mon, 23 Sep 2002 12:04:00 -0700, Dave Olien <dmo@osdl.org> said:

  Dave> #ifdef __ia64__
  Dave> - writeq(Virtual_to_Bus64(CommandMailbox),
  Dave> + writeq(CommandMailboxDMA,
  Dave> ControllerBaseAddress + DAC960_LP_CommandMailboxBusAddressOffset);
  Dave> #else
  Dave> - writel(Virtual_to_Bus32(CommandMailbox),
  Dave> + writel(CommandMailboxDMA,
  Dave> ControllerBaseAddress + DAC960_LP_CommandMailboxBusAddressOffset);
  Dave> #endif

This looks like a porting-nightmare in the making. There's got to be a
better way to determine whether you need a writeq() vs. a writel().

        --david
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon Sep 23 2002 - 22:00:39 EST