Re: [PATCH] LTT for 2.5.37 2/9: Trace driver

• Next message: Robert Love: "Re: 2.5.37 lockup with dbench 36 and make -j3 bzImage and PREEMPT=y."
• Previous message: Robert Love: "Re: [PATCH] de-xchg fork.c"
• In reply to: Pavel Machek: "Re: [PATCH] LTT for 2.5.37 2/9: Trace driver"
• Next in thread: Karim Yaghmour: "Re: [PATCH] LTT for 2.5.37 2/9: Trace driver"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, 22 Sep 2002, Pavel Machek wrote:

> Hi!
>
> > +/* Driver */
> > +static int sMajorNumber; /* Major number of the tracer */
> > +static int sOpenCount; /* Number of times device is open */
> > +/* Locking */
>
> Why *s*OpenCount? Some creeping infection by hungarian notation?
>

int YesItLooksAsThoughSomeOfThisHasCreptIntoTheKernelAsWell = TRUE;

Methinks it started in a BusLogic driver and wasn't stamped out
before it spread and infected everything else!

Cheers,
Dick Johnson
Penguin : Linux version 2.4.18 on an i686 machine (797.90 BogoMips).
The US military has given us many words, FUBAR, SNAFU, now ENRON.
Yes, top management were graduates of West Point and Annapolis.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Robert Love: "Re: 2.5.37 lockup with dbench 36 and make -j3 bzImage and PREEMPT=y."
• Previous message: Robert Love: "Re: [PATCH] de-xchg fork.c"
• In reply to: Pavel Machek: "Re: [PATCH] LTT for 2.5.37 2/9: Trace driver"
• Next in thread: Karim Yaghmour: "Re: [PATCH] LTT for 2.5.37 2/9: Trace driver"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Sep 23 2002 - 22:00:39 EST