[PATCH] n_tty.c buglet breaks error returns

From: Jeff Dike (jdike@karaya.com)
Date: Sat Sep 21 2002 - 12:58:30 EST


The tty SIGIO fix that went into 2.4.19 breaks error returns from the
underlying driver. Currently, any errors from the driver causes write_chan
to call schedule() rather than returning the error.

This broke the UML test suite, the fix below makes it work again.

                                Jeff

--- orig/drivers/char/n_tty.c Tue Sep 3 17:07:15 2002
+++ um/drivers/char/n_tty.c Sat Sep 21 13:22:32 2002
@@ -1180,7 +1180,7 @@
                         while (nr > 0) {
                                 ssize_t num = opost_block(tty, b, nr);
                                 if (num < 0){
- if(num != -EAGAIN)
+ if(num == -EAGAIN)
                                                 break;
                                         retval = num;
                                         goto break_out;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Sep 23 2002 - 22:00:33 EST