Re: [2.5.36] oops when reading /proc/locks

From: Matthew Wilcox (willy@debian.org)
Date: Thu Sep 19 2002 - 15:16:23 EST

Next message: Christoph Hellwig: "Re: [patch] generic-pidhash-2.5.36-J2, BK-curr"
Previous message: Greg KH: "Re: [PATCH] In-kernel module loader 1/7"
Maybe in reply to: Burton Windle: "[2.5.36] oops when reading /proc/locks"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

[note: please cc me or linux-fsdevel when reporting file locking bugs;
i only read linux-kernel on the web and as time permits]

It looks to me like your dereference comes from this line:

if (fl->fl_file != NULL)
inode = fl->fl_file->f_dentry->d_inode;

and, if my terribly weak x86 assembler isn't deceiving me, f_dentry
is NULL. Since you can reproduce this at will, could you insert some
debugging for me?

        if (fl->fl_file != NULL) {
                if (fl->fl_file->f_dentry) {
                        inode = fl->fl_file->f_dentry->d_inode;
                } else {
                        printk(KERN_EMERG "null dentry at %d\n", id);
                }
        }

That will avoid the oops, and tell us who managed to set a file lock on
a file without a dentry.

-- 
Revolutions do not require corporate support.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Christoph Hellwig: "Re: [patch] generic-pidhash-2.5.36-J2, BK-curr"
Previous message: Greg KH: "Re: [PATCH] In-kernel module loader 1/7"
Maybe in reply to: Burton Windle: "[2.5.36] oops when reading /proc/locks"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Sep 23 2002 - 22:00:27 EST