Re: 2.5.35 make race?

From: Sam Ravnborg (sam@ravnborg.org)
Date: Tue Sep 17 2002 - 11:42:18 EST


On Tue, Sep 17, 2002 at 05:33:45PM +1000, Rusty Russell wrote:
> Hi Kai,
>
> First make -j3 on a 2-way SMP box fails. The second one
> succeeds. I think a dependency is missing?

Yep, "if_changed_dep" uses fixdep, so a dependency to scripts is needed.
Added echo_target as well, so the result file is printed as well.
 

===== Makefile 1.297 vs edited =====
--- 1.297/Makefile Mon Sep 16 02:45:07 2002
+++ edited/Makefile Tue Sep 17 18:38:37 2002
@@ -323,7 +323,7 @@
 
 AFLAGS_vmlinux.lds.o += -P -C -U$(ARCH)
 
-arch/$(ARCH)/vmlinux.lds.s: arch/$(ARCH)/vmlinux.lds.S FORCE
+arch/$(ARCH)/vmlinux.lds.s: arch/$(ARCH)/vmlinux.lds.S scripts FORCE
         $(call if_changed_dep,as_s_S)
 
 targets += arch/$(ARCH)/vmlinux.lds.s
@@ -788,6 +788,7 @@
 
 # FIXME Should go into a make.lib or something
 # ===========================================================================
+echo_target = $(RELDIR)/$@
 
 a_flags = -Wp,-MD,$(depfile) $(AFLAGS) $(NOSTDINC_FLAGS) \
           $(modkern_aflags) $(EXTRA_AFLAGS) $(AFLAGS_$(*F).o)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Sep 23 2002 - 22:00:19 EST