Re: Early SPECWeb99 results on 2.5.33 with TSO on e1000

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Mon Sep 16 2002 - 18:48:37 EST

Next message: Linus Torvalds: "Re: [PATCH] BUG(): sched.c: Line 944"
Previous message: David S. Miller: "Re: bridge-netfilter patch"
In reply to: David S. Miller: "Re: Early SPECWeb99 results on 2.5.33 with TSO on e1000"
Next in thread: David S. Miller: "Re: Early SPECWeb99 results on 2.5.33 with TSO on e1000"
Reply: David S. Miller: "Re: Early SPECWeb99 results on 2.5.33 with TSO on e1000"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

David S. Miller wrote:
> From: Jeff Garzik <jgarzik@mandrakesoft.com>
> Date: Mon, 16 Sep 2002 19:08:15 -0400
>
> I was rather disappointed when file->file sendfile was [purposefully?]
> broken in 2.5.x...
>
> What change made this happen?

I dunno when it happened, but 2.5.x now returns EINVAL for all
file->file cases.

In 2.4.x, if sendpage is NULL, file_send_actor in mm/filemap.c faked a
call to fops->write().
In 2.5.x, if sendpage is NULL, EINVAL is unconditionally returned.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Linus Torvalds: "Re: [PATCH] BUG(): sched.c: Line 944"
Previous message: David S. Miller: "Re: bridge-netfilter patch"
In reply to: David S. Miller: "Re: Early SPECWeb99 results on 2.5.33 with TSO on e1000"
Next in thread: David S. Miller: "Re: Early SPECWeb99 results on 2.5.33 with TSO on e1000"
Reply: David S. Miller: "Re: Early SPECWeb99 results on 2.5.33 with TSO on e1000"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Sep 23 2002 - 22:00:18 EST