Re: [PATCH] Fix for ptrace breakage

From: Ingo Molnar (mingo@elte.hu)
Date: Mon Sep 16 2002 - 06:23:59 EST

> This patch fixes the following,
>
> - race condition of ptrace flag
> - sent odd signal to the tracer
> - broken before behavior

(looks good to me). I'm wondering about the following:

- while (!list_empty(&current->children))
- zap_thread(list_entry(current->children.next,struct task_struct,sibling), current, 0);
- while (!list_empty(&current->ptrace_children))
- zap_thread(list_entry(current->ptrace_children.next,struct task_struct,ptrace_list), current, 1);
+ while ((p = eldest_child(current)) != NULL)
+ zap_thread(p, current);
         BUG_ON(!list_empty(&current->children));

is it guaranteed that at this point current->ptrace_children is empty?

        Ingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon Sep 23 2002 - 22:00:16 EST