Re: [PATCH] 1/8 LTT for 2.5.33: Core infrastructure

From: Christoph Hellwig (hch@infradead.org)
Date: Fri Sep 06 2002 - 20:28:48 EST


On Fri, Sep 06, 2002 at 06:15:53PM -0400, Karim Yaghmour wrote:
> +endif
> +
> +ifdef CONFIG_TRACE
> +obj-y += trace.o
> endif

Please try to understand 2.4/2.5-style Makefile first.

>
> +/* Structure packing within the trace */
> +#if LTT_UNPACKED_STRUCTS
> +#define LTT_PACKED_STRUCT
> +#else /* if LTT_UNPACKED_STRUCTS */
> +#define LTT_PACKED_STRUCT __attribute__ ((packed))
> +#endif /* if LTT_UNPACKED_STRUCTS */

I can't see anything defining LTT_UNPACKED_STRUCTS in this patch.

> +int unregister_tracer
> + (tracer_call /* The tracer function */ );

Did you ever read Documentation/CodingStyle?

It would be helpful if you explain what exactly this patch doesm btw.
It's not really obvious from the the patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 07 2002 - 22:00:31 EST