Re: [PATCH] iowait stats for 2.5.33

From: Andrew Morton (akpm@zip.com.au)
Date: Fri Sep 06 2002 - 12:03:05 EST


Rik van Riel wrote:
>
> Hi,
>
> the following patch, against 2.5.33-mm4, implements iowait
> statistics in /proc/stat.

trivial: I'd be inclined to use:

void iowait_schedule()
{
        atomic_inc(...);
        schedule();
        atomic_dec(...);
}

less trivial: there are times when an io wait is deliberate:
in the context of balance_dirty_pages(), and (newly) in the
context of page reclaim when current->backing_dev_info is
non-zero.

Given that this is a deliberate throttling sleep, perhaps it
should not be included in the accounting? That way we only
account for the accidental, undesirable sleeps, and reads
and such.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 07 2002 - 22:00:29 EST