On 6 Sep 2002, Paul Larson wrote:
> It looks like this change dropped us back to the same error all this was
> originally supposed to fix. When you hit PID_MAX, get_pid() starts
> looping forever looking for a free pid and hangs. I could probably make
> my original fix work on this very easily if you'd like.
yes please send a patch for this. Reintroduction of the looping bug was
unintended.
> I wonder though, would it be possible to do this in a more simple way by
> just throttling max_threads back to something more sane if it gets
> defaulted too high? Since it gets checked before we even get to the
> get_pid call in copy_process(). That would keep the number of processes
> down to a sane level without the risk.
this is a good approach as well, but now pid_max can be adjusted runtime
so truncating max_threads as a side-effect looks a bit problematic. We
should rather fail the fork() cleanly.
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Sep 07 2002 - 22:00:29 EST