Re: [PATCH] 2.4.20-pre5-ac2: Promise Controller LBA48 DMA fixed

From: Horst von Brand (vonbrand@inf.utfsm.cl)
Date: Thu Sep 05 2002 - 09:35:35 EST


Mike Isely <isely@pobox.com> said:
> On Thu, 5 Sep 2002, Henning P. Schmiedehausen wrote:
>
> > Mike Isely <isely@pobox.com> writes:
> >
> > >The trivial patch at the end of this text fixes DMA w/ LBA48 problems
> >
> > More readable would be:
> >
> > >- if (!hwif->pci_dev->device == PCI_DEVICE_ID_PROMISE_20246) {
> > >+ if (!(hwif->pci_dev->device == PCI_DEVICE_ID_PROMISE_20246)) {
> >
> > if (hwif->pci_dev->device != PCI_DEVICE_ID_PROMISE_20246) {
> >
>
> Yes that is true. But this is Andre's code and it seemed to me to be
> more important to follow his style. But whatever...

What is wrong with != here?

-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                     Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria              +56 32 654239
Casilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 07 2002 - 22:00:25 EST