Re: [reiserfs-dev] Re: [PATCH] sparc32: wrong type of nlink_t

From: Oleg Drokin (green@namesys.com)
Date: Thu Sep 05 2002 - 09:17:21 EST


Hello!

On Thu, Sep 05, 2002 at 10:03:44AM -0400, Chris Mason wrote:

> read the -noleaf description on the find man page to see why we need to
> set the directory link count to 1 when we are lying to userspace about
> the actual link count on directories.

There is nothing about nlink == 1 means assume -noleaf, so it should not work
with old way too, right? Have anybody verified? ;)

Actually patch might be easily modified to represent i_nlink == 1 for
large directories, but still maintain correct on-disk nlink count.
(and show maximal possible nlink count for regular files. Hm,
I wonder if tar and stuff would break if met with file that have
67000 hardlinks ;) ).

> find isn't the only program that makes this assumption (it's just the
> only one I can think of ;-)

All of these programs are broken if there is no way to turn this feature off
then. ;)

> Other than that the patch (the second one diffed against the correct
> tree) looks sane.

Good.

Bye,
    Oleg
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 07 2002 - 22:00:25 EST