Re: TCP Segmentation Offloading (TSO)

From: H. Peter Anvin (hpa@zytor.com)
Date: Wed Sep 04 2002 - 17:41:19 EST


Gabriel Paubert wrote:
> On 3 Sep 2002, H. Peter Anvin wrote:
>
> [Sorry HPA, I forgot to cc to linux-kernel the first time.]
>
>
>>>P.S.
>>> Using "bswap" is little bit tricky.
>>>
>>
>>It needs to be protected by CONFIG_I486 and alternate code implemented
>>for i386 (xchg %al,%ah; rol $16,%eax, xchg %al,%ah for example.)
>
>
> While it would work, this sequence is overkill. Unless I'm mistaken, the
> only property of bswap which is used in this case is that it swaps even
> and odd bytes, which can be done by a simple "roll $8,%eax" (or rorl).
>
> I believe that bswap is one byte shorter than roll. In any case, using a
> rotate might be the right thing to do on other architectures.
>

And again, I think you'll find the rotate faster on at least some x86 cores.

        -hpa

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 07 2002 - 22:00:23 EST