Re: Large block device patch, part 1 of 9

From: Daniel Phillips (phillips@arcor.de)
Date: Tue Sep 03 2002 - 15:19:29 EST


On Tuesday 03 September 2002 22:04, Benjamin LaHaise wrote:
> On Tue, Sep 03, 2002 at 10:02:38PM +0200, Daniel Phillips wrote:
> > If you must have a clever macro:
> >
> > #define lli(foo) (long long int) (foo)
> > #define llu(foo) (long long unsigned) (foo)
> >
> > The %lli/%llu have to be there in the format string (modulo as-yet-uninvented
> > printk hackery) so the cast might as well be there as well.
>
> Do you not read the messages in a thread before posting?
>
> static inline long long llsect(sector_t sect) { return sect; }
>
> was the suggestion.

I didn't like it, I thought it was awkward. This is better:

   printk("%lli ", llu(sect));

and

   printk("%lli ", (long long unsigned) sect);

is probably better yet. Why get fancy.

-- 
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 07 2002 - 22:00:18 EST